search

spacetelescope / exovetter

Exoplanet vetting
https://exovetter.readthedocs.io
BSD 3-Clause "New" or "Revised" License
6 stars 5 forks source link

Sm tojson #46

Closed mustaric closed 3 years ago

mustaric commented 3 years ago

This adds code to write a tce to json and read it back out again. It appears to work, though there may be a better way.

It still needs a test and would be quite pleased if someone added one. I wasn't sure if a test could write out and read in files.

codecov[bot] commented 3 years ago

Codecov Report

Merging #46 (038683c) into master (50bca38) will decrease coverage by 0.65%. The diff coverage is 64.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
- Coverage   81.78%   81.13%   -0.66%     
==========================================
  Files          14       14              
  Lines         917      949      +32     
==========================================
+ Hits          750      770      +20     
- Misses        167      179      +12
Impacted Files Coverage Δ
exovetter/tce.py 77.96% <62.50%> (-18.34%) :arrow_down:
exovetter/trapezoid_fit.py 86.97% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 50bca38...038683c. Read the comment docs.

pllim commented 3 years ago

"DeprecationWarning: np.int is a deprecated alias for the builtin int." is unfortunate because it does need to be fixed, but not by us; so I guess I'll add this to the ignore list too.

pllim commented 3 years ago

I fixed the warnings, but also left comments on how you can push this forward. FYI.