search

spacetelescope / exovetter

Exoplanet vetting
https://exovetter.readthedocs.io
BSD 3-Clause "New" or "Revised" License
6 stars 5 forks source link

ModShift cleanup #51

Closed mustaric closed 3 years ago

mustaric commented 3 years ago

Fix Modshift Plotting so that it plots two orbits instead of one. Added Fred calculation. Fixed the lightkurve v2 issue, so vetters calls it correctly.

codecov[bot] commented 3 years ago

Codecov Report

Merging #51 (bc14d36) into master (ede22fb) will increase coverage by 0.85%. The diff coverage is 64.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   79.96%   80.82%   +0.85%     
==========================================
  Files          18       18              
  Lines        1188     1194       +6     
==========================================
+ Hits          950      965      +15     
+ Misses        238      229       -9
Impacted Files Coverage Δ
exovetter/vetters.py 87.00% <10.00%> (+0.86%) :arrow_up:
exovetter/modshift/modshift.py 89.72% <100.00%> (ø)
exovetter/modshift/plotmodshift.py 79.06% <100.00%> (+23.80%) :arrow_up:
conftest.py 100.00% <0.00%> (ø)
exovetter/lightkurve_utils.py 72.72% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ede22fb...bc14d36. Read the comment docs.

mustaric commented 3 years ago

I'm abandoning this pull request as it became too painful to try to merge with master.

Days like these I seriously question why git was implemented the way it was...