search

spacetelescope / exovetter

Exoplanet vetting
https://exovetter.readthedocs.io
BSD 3-Clause "New" or "Revised" License
6 stars 5 forks source link

Remove an assert from modshift #58

Open mustaric opened 3 years ago

mustaric commented 3 years ago

An assert in modshift would be better as as warning and returning a default value.

codecov[bot] commented 3 years ago

Codecov Report

Merging #58 (e0e74ec) into master (cfe722b) will decrease coverage by 0.05%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   80.75%   80.70%   -0.06%     
==========================================
  Files          18       18              
  Lines        1195     1197       +2     
==========================================
+ Hits          965      966       +1     
- Misses        230      231       +1
Impacted Files Coverage Δ
exovetter/modshift/modshift.py 89.18% <50.00%> (-0.54%) :arrow_down:
exovetter/model.py 90.32% <0.00%> (ø)
exovetter/vetters.py 86.13% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cfe722b...e0e74ec. Read the comment docs.