search

spacetelescope / exovetter

Exoplanet vetting
https://exovetter.readthedocs.io
BSD 3-Clause "New" or "Revised" License
6 stars 5 forks source link

Fm centroid #59

Closed fergalm closed 3 years ago

fergalm commented 3 years ago

Will we be able to merge this if all the test fail?

pllim commented 3 years ago

Not a good idea to merge PR when tests are not passing.

codecov[bot] commented 3 years ago

Codecov Report

Merging #59 (e50357b) into master (e7528bf) will decrease coverage by 5.90%. The diff coverage is 53.15%.

:exclamation: Current head e50357b differs from pull request most recent head 9d080d1. Consider uploading reports for the commit 9d080d1 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   80.75%   74.85%   -5.91%     
==========================================
  Files          18       21       +3     
  Lines        1195     1519     +324     
==========================================
+ Hits          965     1137     +172     
- Misses        230      382     +152
Impacted Files Coverage Δ
exovetter/centroid/disp.py 14.28% <14.28%> (ø)
exovetter/lightkurve_utils.py 56.25% <20.00%> (-16.48%) :arrow_down:
exovetter/centroid/covar.py 41.11% <41.11%> (ø)
exovetter/vetters.py 76.66% <53.84%> (-9.48%) :arrow_down:
exovetter/utils.py 68.64% <58.62%> (-2.06%) :arrow_down:
exovetter/centroid/centroid.py 82.14% <82.14%> (ø)
exovetter/centroid/fastpsffit.py 92.68% <92.68%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e7528bf...9d080d1. Read the comment docs.