spacetelescope / gwcs

Generalized World Coordinate System: provides tools for managing WCS in a general way
https://gwcs.readthedocs.io/en/latest/
46 stars 48 forks source link

add pixel_shape to WCS converter #480

Closed braingram closed 10 months ago

braingram commented 11 months ago

Fixes: #474

Schema changes to add pixel_shape to the wcs schema are included in: https://github.com/asdf-format/asdf-wcs-schemas/pull/56

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2b571a9) 87.25% compared to head (f765464) 87.28%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #480 +/- ## ========================================== + Coverage 87.25% 87.28% +0.02% ========================================== Files 22 22 Lines 3814 3821 +7 ========================================== + Hits 3328 3335 +7 Misses 486 486 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nden commented 10 months ago

LGTM. Should a wcs_schemas release be made so this can pick up the change?

braingram commented 10 months ago

Releasing asdf-wcs-schemas once https://github.com/asdf-format/asdf-wcs-schemas/pull/56 sounds good.

The changes here are compatible with the existing 1.1.0 schema (it allows additionalProperties). I don't think the asdf-wcs-schemas release needs to be coordinated with any gwcs release. The conditions for a user could be as follows: