spacetelescope / gwcs

Generalized World Coordinate System: provides tools for managing WCS in a general way
https://gwcs.readthedocs.io/en/latest/
47 stars 48 forks source link

Add on spring cleaning #486

Closed nden closed 1 month ago

nden commented 11 months ago

This PR adds on #457. It includes all changes by @Cadair in that PR. All, but the SlicedWCS, tests pass locally.

@Cadair @perrygreenfield

codecov[bot] commented 11 months ago

Codecov Report

Attention: Patch coverage is 95.96774% with 10 lines in your changes missing coverage. Please review.

Project coverage is 87.05%. Comparing base (8117b3c) to head (4685bcd). Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
gwcs/coordinate_frames.py 97.05% 5 Missing :warning:
gwcs/wcs.py 91.37% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #486 +/- ## ========================================== - Coverage 87.25% 87.05% -0.20% ========================================== Files 22 22 Lines 3814 3717 -97 ========================================== - Hits 3328 3236 -92 + Misses 486 481 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Cadair commented 1 month ago

I just discovered another bug that's fixed by this, so I guess it's time for me to resurrect it again

Cadair commented 1 month ago

I have merged this back into #457 so I can keep pushing there. This can be closed.