search

spacetelescope / gwcs

Generalized World Coordinate System: provides tools for managing WCS in a general way
https://gwcs.readthedocs.io/en/latest/
46 stars 48 forks source link

Respect the bounding_box in inverse transforms #498

Open nden opened 4 months ago

nden commented 4 months ago

Fixes #496

This is a fix similar in spirit to #497 though it uses methods of modeling.ModelBoundingBox .

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 64.47368% with 27 lines in your changes missing coverage. Please review.

Project coverage is 86.80%. Comparing base (eb9d316) to head (cd325e4). Report is 9 commits behind head on master.

Files Patch % Lines
gwcs/tests/conftest.py 30.00% 14 Missing :warning:
gwcs/wcs.py 77.08% 11 Missing :warning:
gwcs/api.py 60.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #498 +/- ## ========================================== - Coverage 87.28% 86.80% -0.48% ========================================== Files 22 21 -1 Lines 3821 3865 +44 ========================================== + Hits 3335 3355 +20 - Misses 486 510 +24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nden commented 4 months ago

@bmorris3 Do you mind testing this PR with your code? Since this changes the functionality, there are a number of failures in the jwst pipeline. I'll need to address them before this is merged or make this the non-default behavior.

nden commented 4 months ago

@Cadair Can you take a look at this PR and see if it's OK for sun related code? Note that enforcing the bounding_box on the inverse transform now works and this can change results. If reproducing the bug is necessary, a parameter should be passed with_bounding_box=False.