Closed dulude closed 7 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Hello @FDauphin, I am uncertain who was tasked with working on this notebook. I wanted to tag you so that I can inform all the parties involved in this matter and add this to the queue for a technical review. There is an execution error, which can be found here: https://github.com/spacetelescope/hst_notebooks/actions/runs/7744396146/job/21118057705?pr=127.
Hello @FDauphin, I am uncertain who was tasked with working on this notebook. I wanted to tag you so that I can inform all the parties involved in this matter and add this to the queue for a technical review. There is an execution error, which can be found here: https://github.com/spacetelescope/hst_notebooks/actions/runs/7744396146/job/21118057705?pr=127.
@haticekaratay Thanks for the heads up. I believe @bjkuhn was tasked with this notebook a few months ago, but we wanted to focus on fully ingesting WFC3 notebooks first. I can chat with him offline about time constraints for fixing this notebook and get back to you 👍🏾
@haticekaratay To keep you in the loop, there are a few issues organizationally the INS teams need to address before moving forward with this PR:
@mackjenn and I are working on addressing these issues so for now there is no action needed to be taken on this PR. If it's easier for your team to stop getting CI failure alerts and focus on higher priority PRs, we can close this PR and reopen (or open a new one) when we have a more organized plan. Please let me know if you have any questions, comments, concerns, or clarifications and thanks again for your continuous effort towards this repository 🙂
@haticekaratay We have decided to close this PR to allow DMD to focus on other higher priority tasks. We will reach out when we are ready to push the updated Drizzlepac notebooks and requirement texts. Thank you for your patience 🙌🏾
Relevant Ticket
High-Level Summary
Summary of Changes
This notebook checklist has been made available to us by the Notebooks For All team. Its purpose is to serve as a guide for both the notebook author and the technical reviewer highlighting critical aspects to consider when striving to develop an accessible and effective notebook.
The First Cell
<h1>
or# in markdown
).1., 2.,
etc. in Markdown).The Rest of the Cells
#
in Markdown) used in the notebook.Text
Code
Images
[ ] All images (jpg, png, svgs) have an image description. This could be
alt
property)alt
attribute with no value)[ ] Any text present in images exists in a text form outside of the image (this can be alt text, captions, or surrounding text.)
Visualizations
[ ] All visualizations have an image description. Review the previous section, Images, for more information on how to add it.
[ ] Visualization descriptions include
[ ] All visualizations and their parts have enough color contrast (color contrast checker) to be legible. Remember that transparent colors have lower contrast than their opaque versions.
[ ] All visualizations convey information with more visual cues than color coding. Use text labels, patterns, or icons alongside color to achieve this.
[ ] All visualizations have an additional way for notebook readers to access the information. Linking to the original data, including a table of the data in the same notebook, or sonifying the plot are all options.