spacetelescope / hst_notebooks

Generated Notebooks HTML
https://spacetelescope.github.io/hst_notebooks/
BSD 3-Clause "New" or "Revised" License
10 stars 15 forks source link

Fix and deploy dormant DrizzlePac notebook "align_mosaics.py" #127

Closed dulude closed 7 months ago

dulude commented 12 months ago

Relevant Ticket

High-Level Summary

Summary of Changes


This notebook checklist has been made available to us by the Notebooks For All team. Its purpose is to serve as a guide for both the notebook author and the technical reviewer highlighting critical aspects to consider when striving to develop an accessible and effective notebook.

The First Cell

The Rest of the Cells

Text

Code

Images

Visualizations

review-notebook-app[bot] commented 12 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

haticekaratay commented 8 months ago

Hello @FDauphin, I am uncertain who was tasked with working on this notebook. I wanted to tag you so that I can inform all the parties involved in this matter and add this to the queue for a technical review. There is an execution error, which can be found here: https://github.com/spacetelescope/hst_notebooks/actions/runs/7744396146/job/21118057705?pr=127.

FDauphin commented 8 months ago

Hello @FDauphin, I am uncertain who was tasked with working on this notebook. I wanted to tag you so that I can inform all the parties involved in this matter and add this to the queue for a technical review. There is an execution error, which can be found here: https://github.com/spacetelescope/hst_notebooks/actions/runs/7744396146/job/21118057705?pr=127.

@haticekaratay Thanks for the heads up. I believe @bjkuhn was tasked with this notebook a few months ago, but we wanted to focus on fully ingesting WFC3 notebooks first. I can chat with him offline about time constraints for fixing this notebook and get back to you 👍🏾

FDauphin commented 8 months ago

@haticekaratay To keep you in the loop, there are a few issues organizationally the INS teams need to address before moving forward with this PR:

  1. @mackjenn has noticed several Drizzlepac notebooks aren't working as expected (either code wise or science wise) besides this one. Most notebooks were developed in 2018 and are now most likely stale, causing some errors on both sides. More time than expected will be needed to test them and confirm we are getting expected results before opening additional PRs.
  2. @bjkuhn and I are listed as the current notebook curators for Drizzlepac, but I think it would be preferred if the curator has an in-depth knowledge of Drizzlepac to properly support notebook authors due to the package's complexity. We need to determine if this role is simply a delegator to authors or if they are also responsible for addressing package failure, function deprecation, and unexpected outputs.
  3. A few of the Drizzlepac notebooks were developed by people who are no longer within HST, and these notebooks were not properly transitioned to a new author. Some new developers were chosen to fix the notebooks during ingest, but we need to confirm who is responsible for fixes long term (i.e. a new designated author).
  4. There is currently no "Drizzlepac" team responsible for maintaining the repository, which makes it difficult to delegate tasks. All the other notebooks naturally fall into instrument teams so a similar structure should be set in place to better support the repository.

@mackjenn and I are working on addressing these issues so for now there is no action needed to be taken on this PR. If it's easier for your team to stop getting CI failure alerts and focus on higher priority PRs, we can close this PR and reopen (or open a new one) when we have a more organized plan. Please let me know if you have any questions, comments, concerns, or clarifications and thanks again for your continuous effort towards this repository 🙂

FDauphin commented 7 months ago

@haticekaratay We have decided to close this PR to allow DMD to focus on other higher priority tasks. We will reach out when we are ready to push the updated Drizzlepac notebooks and requirement texts. Thank you for your patience 🙌🏾