search

spacetelescope / hst_notebooks

Generated Notebooks HTML
https://spacetelescope.github.io/hst_notebooks/
BSD 3-Clause "New" or "Revised" License
10 stars 15 forks source link

added acs_focus_diverse_epsfs for review #132

Closed gsanand closed 8 months ago

gsanand commented 11 months ago

acstools 3.7.0 is now available, so the notebook is ready for review

review-notebook-app[bot] commented 11 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

haticekaratay commented 11 months ago

acstools 3.7.0 is now available, so the notebook is ready for review

Thank you, @gsanand, for submitting your notebook. We have added it to our queue for technical review.

haticekaratay commented 11 months ago

To begin the review, please address execution errors from the logs and style errors shown here.

gsanand commented 11 months ago

hi @haticekaratay I fixed the PEP8 errors but I can't figure out how to deal with the execution issue. it is supposed to download a file, so maybe it is looking for it in some place that is not obvious to me?

haticekaratay commented 11 months ago

Hello @dulude and @mgough-970,

We're facing an issue with our CI where it is unable to locate the retrieved_download. We need your assistance in figuring out the root cause of the problem.

We have tested the notebook locally and it works perfectly fine. We even tried adding the downloads directory to ensure that CI would find the correct path, but unfortunately, it still can't find the downloads.

We would greatly appreciate any help you can offer us. Thank you.

dulude commented 11 months ago

We're facing an issue with our CI where it is unable to locate the retrieved_download. We need your assistance in figuring out the root cause of the problem.

We have tested the notebook locally and it works perfectly fine. We even tried adding the downloads directory to ensure that CI would find the correct path, but unfortunately, it still can't find the downloads.

We would greatly appreciate any help you can offer us. Thank you.

Hey @gsanand , a possible stop-gap solution to this might be to skip use of psf_retriever all together for now and download the data with astroquery, as you do further down in the notebook. Astroquery widely used in numerous other notebooks without issue. That way, you could get the notebook published now and we can circle back to the issue later.

gsanand commented 11 months ago

Hi @dulude, if I understand your suggestion correctly, then that is not possible, as the ePSFs are only available through the custom AWS API that I have set up (and not through MAST or anything like that).

haticekaratay commented 8 months ago

195 is created to enable notebook deployment on the GitHub pages.