spacetelescope / hst_notebooks

Generated Notebooks HTML
https://spacetelescope.github.io/hst_notebooks/
BSD 3-Clause "New" or "Revised" License
10 stars 15 forks source link

Updated syntax used to display images so they properly render in generated HTML pages #149

Closed dulude closed 10 months ago

dulude commented 10 months ago

Relevant PRs and JIRA Tickets

Summary


This notebook checklist has been made available to us by the Notebooks For All team. Its purpose is to serve as a guide for both the notebook author and the technical reviewer highlighting critical aspects to consider when striving to develop an accessible and effective notebook.

The First Cell

The Rest of the Cells

Text

Code

Images

Visualizations

review-notebook-app[bot] commented 10 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

dulude commented 10 months ago

Hey @haticekaratay , I'm not sure why there are PEP8 and execution errors in approved notebooks. None of my changes touched any of the code cells. The PEP8 issues are pretty minimal, and I could easily fix those. However, I don't feel comfortable troubleshooting the execution errors.

haticekaratay commented 10 months ago

Regarding CI failures, addressing them is outside the scope of this work and will be handled by the notebook authors. Thank you for your contribution.