search

spacetelescope / hst_notebooks

Generated Notebooks HTML
https://spacetelescope.github.io/hst_notebooks/
BSD 3-Clause "New" or "Revised" License
10 stars 15 forks source link

Added CRDS to STIS notebooks requirements #185

Closed sean-lockwood closed 8 months ago

sean-lockwood commented 8 months ago

Modifying requirements files for STIS cross-correlation.ipynb and calstis_2d_ccd.ipynb to add the CRDS package. Hopefully this will allow calstis to access reference files when reprocessing data.

These are pre-existing notebooks.

sean-lockwood commented 8 months ago

@haticekaratay - How can we get this to run the regression suite on the two notebooks?

cc: @Jackie-Brown

sean-lockwood commented 8 months ago

@haticekaratay -

Looks like the requirements.txt and pre-requirements.sh files do not trigger the CI:

https://github.com/spacetelescope/hst_notebooks/blob/main/.github/workflows/ci_runner.yml#L15

haticekaratay commented 8 months ago

@haticekaratay -

Looks like the requirements.txt and pre-requirements.sh files do not trigger the CI:

https://github.com/spacetelescope/hst_notebooks/blob/main/.github/workflows/ci_runner.yml#L15

Thanks, @sean-lockwood, for working on this. It's triggered by an edit to the notebook due to the way the CI is set up. I suggest making a small change to the notebook.

sean-lockwood commented 8 months ago

@Jackie-Brown - Would you mind making the minor changes to the two notebooks, at your convenience?

review-notebook-app[bot] commented 8 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

Jackie-Brown commented 8 months ago

@sean-lockwood made some minor text changes and checks are now running