spacetelescope / hst_notebooks

Generated Notebooks HTML
https://spacetelescope.github.io/hst_notebooks/
BSD 3-Clause "New" or "Revised" License
10 stars 15 forks source link

Edit COS Extract.ipynb to execute with workflow #206

Open srosagomez opened 5 months ago

srosagomez commented 5 months ago

Edited the variable names in COS Extract.ipynb since they were causing a false positive from the workflow.

This notebook checklist has been made available to us by the Notebooks For All team. Its purpose is to serve as a guide for both the notebook author and the technical reviewer highlighting critical aspects to consider when striving to develop an accessible and effective notebook.

The First Cell

The Rest of the Cells

Text

Code

Images

Visualizations

review-notebook-app[bot] commented 5 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

haticekaratay commented 5 months ago

@dulude, I wanted to inform you that the execution step is passing even though it should fail as there is an internal failure.

dulude commented 5 months ago

@dulude, I wanted to inform you that the execution step is passing even though it should fail as there is an internal failure.

Thanks. I put in ticket SPB-1881 to chase down the issue.

haticekaratay commented 5 months ago

@dulude, I wanted to inform you that the execution step is passing even though it should fail as there is an internal failure.

Thanks. I put in ticket SPB-1881 to chase down the issue.

Thanks @dulude. Both @srosagomez and I confirmed that the notebook runs locally with no issues. This might also be resolved with the fix you are working on.