spacetelescope / hst_notebooks

Generated Notebooks HTML
https://spacetelescope.github.io/hst_notebooks/
BSD 3-Clause "New" or "Revised" License
10 stars 15 forks source link

updates to "align_multiple_visits" and "align_sparse_fields" notebooks #266

Open gsanand opened 2 months ago

gsanand commented 2 months ago

This notebook checklist has been made available to us by the Notebooks For All team. Its purpose is to serve as a guide for both the notebook author and the technical reviewer highlighting critical aspects to consider when striving to develop an accessible and effective notebook.

The First Cell

The Rest of the Cells

Text

Code

Images

Visualizations

review-notebook-app[bot] commented 2 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

mackjenn commented 2 months ago

Would it be more straightforward for CI testing to have these two notebooks in separate PRs?

gsanand commented 2 months ago

@mackjenn good point, I'm not sure. @haticekaratay what would you prefer? happy to make the switch if desired.

haticekaratay commented 1 month ago

@mackjenn good point, I'm not sure. @haticekaratay what would you prefer? happy to make the switch if desired.

Yes, we prefer one notebook for each PR, but let's not go through the trouble of creating a second one this time. I'll review both at once. However, upcoming PRs can be singles. Thanks.

gsanand commented 1 week ago

@mgough-970 @haticekaratay I tried to modify the file handling in hopes that it would help the CI, but now the CI can't even find the image file that is made as part of the notebook itself. I don't really know what to do from here