spacetelescope / hst_notebooks

Generated Notebooks HTML
https://spacetelescope.github.io/hst_notebooks/
BSD 3-Clause "New" or "Revised" License
10 stars 15 forks source link

Revised driz notebook: optimize image sampling #267

Closed rjavila closed 1 month ago

rjavila commented 1 month ago

This notebook checklist has been made available to us by the Notebooks For All team. Its purpose is to serve as a guide for both the notebook author and the technical reviewer highlighting critical aspects to consider when striving to develop an accessible and effective notebook.

The First Cell

The Rest of the Cells

Text

Code

Images

Visualizations

review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

rjavila commented 1 month ago

Hello @haticekaratay. Not sure why the CI check is failing during package installation. I tested my NB by creating a clean environment with python==3.11.7 and then pip installed the packages in the requirements.txt file. The NB ran successfully. Any advice would be appreciated.

haticekaratay commented 1 month ago

Closing this pull request as pull request #268 already contains the updates to this notebook, and it will be reviewed together with that.

mackjenn commented 1 month ago

Hi Hatice, I don't understand why this was closed? This is a different notebook than the one in #268 (using DS9 regions)

What do we need to do to get this notebook running?