Closed rjavila closed 4 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Hi Hatice, It looks like this one passed but is not showing up yet here. Is that expected?
Hi Hatice, It looks like this one passed but is not showing up yet here. Is that expected?
I think this issue has been resolved as I can see the notebook outputs on the provided link.
Hi, The HTML link shows the old version of the notebook from January 2024.
The latest version on github has a yellow bar on the top. https://github.com/spacetelescope/hst_notebooks/blob/main/notebooks/DrizzlePac/use_ds9_regions_in_tweakreg/use_ds9_regions_in_tweakreg.ipynb
Do we need to file separate tickets for the notebooks not getting HTML previews.
This notebook checklist has been made available to us by the Notebooks For All team. Its purpose is to serve as a guide for both the notebook author and the technical reviewer highlighting critical aspects to consider when striving to develop an accessible and effective notebook.
The First Cell
<h1>
or# in markdown
).1., 2.,
etc. in Markdown).The Rest of the Cells
#
in Markdown) used in the notebook.Text
Code
Images
[ ] All images (jpg, png, svgs) have an image description. This could be
alt
property)alt
attribute with no value)[ ] Any text present in images exists in a text form outside of the image (this can be alt text, captions, or surrounding text.)
Visualizations
[ ] All visualizations have an image description. Review the previous section, Images, for more information on how to add it.
[ ] Visualization descriptions include
[ ] All visualizations and their parts have enough color contrast (color contrast checker) to be legible. Remember that transparent colors have lower contrast than their opaque versions.
[ ] All visualizations convey information with more visual cues than color coding. Use text labels, patterns, or icons alongside color to achieve this.
[ ] All visualizations have an additional way for notebook readers to access the information. Linking to the original data, including a table of the data in the same notebook, or sonifying the plot are all options.