Update Drizzlepac satellite trail masking notebook

dvstark commented 1 month ago

This notebook checklist has been made available to us by the Notebooks For All team. Its purpose is to serve as a guide for both the notebook author and the technical reviewer highlighting critical aspects to consider when striving to develop an accessible and effective notebook.

The First Cell

[ ] The title of the notebook in a first-level heading (eg. <h1> or # in markdown).
[ ] A brief description of the notebook.
[ ] A table of contents in an ordered list (1., 2., etc. in Markdown).
[ ] The author(s) and affiliation(s) (if relevant).
[ ] The date first published.
[ ] The date last edited (if relevant).
[ ] A link to the notebook's source(s) (if relevant).

The Rest of the Cells

[ ] There is only one H1 (# in Markdown) used in the notebook.
[ ] The notebook uses other heading tags in order (meaning it does not skip numbers).

Text

[ ] All link text is descriptive. It tells users where they will be taken if they open the link.
[ ] All acronyms are defined at least the first time they are used.
[ ] Field-specific/specialized terms are used when needed, but not excessively.

Code

[ ] Code sections are introduced and explained before they appear in the notebook. This can be fulfilled with a heading in a prior Markdown cell, a sentence preceding it, or a code comment in the code section.
[ ] Code has explanatory comments (if relevant). This is most important for long sections of code.
[ ] If the author has control over the syntax highlighting theme in the notebook, that theme has enough color contrast to be legible.
[ ] Code and code explanations focus on one task at a time. Unless comparison is the point of the notebook, only one method for completing the task is described at a time.

Images

[ ] All images (jpg, png, svgs) have an image description. This could be
- [ ] Alt text (an alt property)
- [ ] Empty alt text for decorative images/images meant to be skipped (an alt attribute with no value)
- [ ] Captions
- [ ] If no other options will work, the image is decribed in surrounding paragraphs.
[ ] Any text present in images exists in a text form outside of the image (this can be alt text, captions, or surrounding text.)

Visualizations

[ ] All visualizations have an image description. Review the previous section, Images, for more information on how to add it.
[ ] Visualization descriptions include
- [ ] The type of visualization (like bar chart, scatter plot, etc.)
- [ ] Title
- [ ] Axis labels and range
- [ ] Key or legend
- [ ] An explanation of the visualization's significance to the notebook (like the trend, an outlier in the data, what the author learned from it, etc.)
[ ] All visualizations and their parts have enough color contrast (color contrast checker) to be legible. Remember that transparent colors have lower contrast than their opaque versions.
[ ] All visualizations convey information with more visual cues than color coding. Use text labels, patterns, or icons alongside color to achieve this.
[ ] All visualizations have an additional way for notebook readers to access the information. Linking to the original data, including a table of the data in the same notebook, or sonifying the plot are all options.

review-notebook-app[bot] commented 1 month ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

dvstark commented 1 month ago

This notebook has been updated in collaboration with Jen Mack and the Drizzlepac team. It contains many general improvements, including an added WFC3 example to go alongside the ACS example. The requirements file has been updated to show only the packages needed to run the notebook in Python3.11.

mackjenn commented 1 month ago

The link is still showing the old notebook. Can someone help?

https://spacetelescope.github.io/hst_notebooks/notebooks/DrizzlePac/mask_satellite/mask_satellite.html

dvstark commented 1 month ago

Is the html version generated automatically from the notebook once it’s on github, or is this something I need to do and then push? If the latter, I’m happy to do so.

-- David V. Stark Staff Scientist II, Science Support HST/ACS Team Space Telescope Science Institute

From: mackjenn @.> Reply-To: spacetelescope/hst_notebooks @.> Date: Thursday, May 30, 2024 at 2:14 PM To: spacetelescope/hst_notebooks @.> Cc: David Stark @.>, Author @.***> Subject: Re: [spacetelescope/hst_notebooks] Update Drizzlepac satellite trail masking notebook (PR #269)

The link is still showing the old notebook. Can someone help?

https://spacetelescope.github.io/hst_notebooks/notebooks/DrizzlePac/mask_satellite/mask_satellite.html https://urldefense.com/v3/__https:/spacetelescope.github.io/hst_notebooks/notebooks/DrizzlePac/mask_satellite/mask_satellite.html__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!z3YNvryVi8G_pAkxdrKGVaaPhiSGPhhrowX5WV12BRRVi7nwHeqNQbNDGiQ0MrHn9xVfzGfBRgCwWvT92Ohk26g$

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/spacetelescope/hst_notebooks/pull/269*issuecomment-2140535129__;Iw!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!z3YNvryVi8G_pAkxdrKGVaaPhiSGPhhrowX5WV12BRRVi7nwHeqNQbNDGiQ0MrHn9xVfzGfBRgCwWvT9tMjDzgw$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ACQIOODEA736UA3CPISMYJDZE5UAVAVCNFSM6AAAAABHYSBP3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBQGUZTKMJSHE__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!z3YNvryVi8G_pAkxdrKGVaaPhiSGPhhrowX5WV12BRRVi7nwHeqNQbNDGiQ0MrHn9xVfzGfBRgCwWvT9ALAnCiE$. You are receiving this because you authored the thread.Message ID: @.***>

haticekaratay commented 1 month ago

Hey @dvstark and @mackjenn, We perform weekly health checks on the notebooks to ensure they still run properly after a merge. If a notebook fails during the weekly execution, it may be due to an update in packages or something similar. When this occurs, you won't see any outputs. Please open a new PR for this notebook. Thanks!

spacetelescope / hst_notebooks