Closed mrevalski closed 3 weeks ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
This notebook has been revised in consultation with J. Mack and the DrizzlePac team. The updates include an improved workflow for WCS solutions that solve previously encountered errors in the notebook, as well as numerous STScI DMD formatting and PEP8 compliance changes. The revised requirements.txt is identical to the previous file in terms of required packages, with updated version numbers that were used in testing. The notebook was tested extensively with stenv2024.02.05.
Hi @mackjenn and @Vb2341, I've completed my updates to this notebook following the newly added code from Varun. I've cleaned up some code, added more detail to some of the descriptions, and resolved PEP8 compliance issues. Could you please let me know if you have any additional suggested revisions before I change this draft to a proper pull request for Hatice? Thanks!
Hi @haticekaratay, this notebook was extensively improved by @mackjenn and @Vb2341 and is now ready for your review!
Apologies for the ping on this, I was simply updating my local and remote branches with the latest changes from main.
Hi @haticekaratay, thank you for the swift review, and for making that small change directly to this branch, both are very much appreciated. Have a great day! 🙂
This notebook checklist has been made available to us by the Notebooks For All team. Its purpose is to serve as a guide for both the notebook author and the technical reviewer highlighting critical aspects to consider when striving to develop an accessible and effective notebook.
The First Cell
<h1>
or# in markdown
).1., 2.,
etc. in Markdown).The Rest of the Cells
#
in Markdown) used in the notebook.Text
Code
Images
[ ] All images (jpg, png, svgs) have an image description. This could be
alt
property)alt
attribute with no value)[ ] Any text present in images exists in a text form outside of the image (this can be alt text, captions, or surrounding text.)
Visualizations
[ ] All visualizations have an image description. Review the previous section, Images, for more information on how to add it.
[ ] Visualization descriptions include
[ ] All visualizations and their parts have enough color contrast (color contrast checker) to be legible. Remember that transparent colors have lower contrast than their opaque versions.
[ ] All visualizations convey information with more visual cues than color coding. Use text labels, patterns, or icons alongside color to achieve this.
[ ] All visualizations have an additional way for notebook readers to access the information. Linking to the original data, including a table of the data in the same notebook, or sonifying the plot are all options.