spacetelescope / hst_notebooks

Generated Notebooks HTML
https://spacetelescope.github.io/hst_notebooks/
BSD 3-Clause "New" or "Revised" License
10 stars 15 forks source link

Revised DrizzlePac Notebook: using_updated_astrometry_solutions #275

Closed mrevalski closed 3 weeks ago

mrevalski commented 1 month ago

This notebook checklist has been made available to us by the Notebooks For All team. Its purpose is to serve as a guide for both the notebook author and the technical reviewer highlighting critical aspects to consider when striving to develop an accessible and effective notebook.

The First Cell

The Rest of the Cells

Text

Code

Images

Visualizations

review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

mrevalski commented 1 month ago

This notebook has been revised in consultation with J. Mack and the DrizzlePac team. The updates include an improved workflow for WCS solutions that solve previously encountered errors in the notebook, as well as numerous STScI DMD formatting and PEP8 compliance changes. The revised requirements.txt is identical to the previous file in terms of required packages, with updated version numbers that were used in testing. The notebook was tested extensively with stenv2024.02.05.

mrevalski commented 1 month ago

Hi @mackjenn and @Vb2341, I've completed my updates to this notebook following the newly added code from Varun. I've cleaned up some code, added more detail to some of the descriptions, and resolved PEP8 compliance issues. Could you please let me know if you have any additional suggested revisions before I change this draft to a proper pull request for Hatice? Thanks!

mrevalski commented 1 month ago

Hi @haticekaratay, this notebook was extensively improved by @mackjenn and @Vb2341 and is now ready for your review!

mrevalski commented 1 month ago

Apologies for the ping on this, I was simply updating my local and remote branches with the latest changes from main.

mrevalski commented 3 weeks ago

Hi @haticekaratay, thank you for the swift review, and for making that small change directly to this branch, both are very much appreciated. Have a great day! 🙂