Closed bjkuhn closed 2 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Hello! I was curious when you anticipate having time to review this notebook? I'm trying to coordinate our work plan. Thanks you.
@bjkuhn, There is an import error, ---> 19 from drizzlepac import astrodrizzle, tweakback, tweakreg https://github.com/spacetelescope/hst_notebooks/actions/runs/9422985456/job/26897266453?pr=284 It could be due to a versioning issue with a dependency or a missing dependency.
@bjkuhn, There is an import error, ---> 19 from drizzlepac import astrodrizzle, tweakback, tweakreg https://github.com/spacetelescope/hst_notebooks/actions/runs/9422985456/job/26897266453?pr=284 It could be due to a versioning issue with a dependency or a missing dependency.
@bjkuhn, I found that the import issue in Astrodrizlle is due to deprecated methods in photutils. To temporarily solve the problem, you can try pinning the requirements.txt file to the old release of photutils, for example, version 1.12.0 instead of 1.13.0. There are no changes to the CI.
@bjkuhn Thanks for your notebook. I learned a lot from reading it. I left a few minor comments.
@haticekaratay all requested changes have been made. Thank you for your review!
@haticekaratay Thanks for your review!
Looks like this one is ready to be merged when you have time to do so. 👍
This notebook checklist has been made available to us by the Notebooks For All team. Its purpose is to serve as a guide for both the notebook author and the technical reviewer highlighting critical aspects to consider when striving to develop an accessible and effective notebook.
The First Cell
<h1>
or# in markdown
).1., 2.,
etc. in Markdown).The Rest of the Cells
#
in Markdown) used in the notebook.Text
Code
Images
[ ] All images (jpg, png, svgs) have an image description. This could be
alt
property)alt
attribute with no value)[ ] Any text present in images exists in a text form outside of the image (this can be alt text, captions, or surrounding text.)
Visualizations
[ ] All visualizations have an image description. Review the previous section, Images, for more information on how to add it.
[ ] Visualization descriptions include
[ ] All visualizations and their parts have enough color contrast (color contrast checker) to be legible. Remember that transparent colors have lower contrast than their opaque versions.
[ ] All visualizations convey information with more visual cues than color coding. Use text labels, patterns, or icons alongside color to achieve this.
[ ] All visualizations have an additional way for notebook readers to access the information. Linking to the original data, including a table of the data in the same notebook, or sonifying the plot are all options.