search

spacetelescope / hst_notebooks

Generated Notebooks HTML
https://spacetelescope.github.io/hst_notebooks/
BSD 3-Clause "New" or "Revised" License
10 stars 15 forks source link

Adding new STIS notebook Low_Count_Uncertainties.ipynb #288

Open Jackie-Brown opened 2 weeks ago

Jackie-Brown commented 2 weeks ago

Added STIS notebook Low_Count_Uncertainties.ipynb, requirements.txt, and pre-requirements.sh

review-notebook-app[bot] commented 2 weeks ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

haticekaratay commented 1 week ago

@Jackie-Brown , I ran this notebook locally and encountered the same error as reported on the CI.

image image
haticekaratay commented 14 hours ago

@Jackie-Brown , another important thing to note is that we are getting a deprecation warning for these two. The notebook will fail when new releases are out. 

UserWarning: GFIT is deprecated - stsci.tools v 3.4.12 is the last version to contain it.Use astropy.modeling instead.
  warnings.warn("GFIT is deprecated - stsci.tools v 3.4.12 is the last version to contain it."
UserWarning: NMPFIT is deprecated - stsci.tools v 3.5 is the last version to contain it.
  warnings.warn("NMPFIT is deprecated - stsci.tools v 3.5 is the last version to contain it.")