search

spacetelescope / hst_notebooks

Generated Notebooks HTML
https://spacetelescope.github.io/hst_notebooks/
BSD 3-Clause "New" or "Revised" License
10 stars 15 forks source link

Spelling Corrections #295

Closed mrevalski closed 1 week ago

mrevalski commented 1 week ago

Hi @FDauphin and @haticekaratay,

I've made several spelling corrections to this notebook, and no changes have been made to the code.

Please let me know if you have any questions!

review-notebook-app[bot] commented 1 week ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

mrevalski commented 1 week ago

The CI failure is due to the recent changes in photutils from 1.12 to 1.13, as discussed by Larry Bradley on Slack. photutils is not directly called in this notebook, but a function within custom drizzlepac code I believe, and so should not prevent merging.

haticekaratay commented 1 week ago

@mrevalski, let's pin the photutils for now. This should address the execution failure.

mrevalski commented 1 week ago

Hi @haticekaratay, I've pinned the version of photutils and that solved the CI failure. As with my other recent PR #294 I'm not sure if I should have write access to merge the pull request myself. Or should this be allowed once all changes are approved?

haticekaratay commented 1 week ago

Hi @haticekaratay, I've pinned the version of photutils and that solved the CI failure. As with my other recent PR #294 I'm not sure if I should have write access to merge the pull request myself. Or should this be allowed once all changes are approved?

Merging it.