spacetelescope / hst_notebooks

Generated Notebooks HTML
https://spacetelescope.github.io/hst_notebooks/
BSD 3-Clause "New" or "Revised" License
10 stars 15 forks source link

Add ACS notebook acs_findsat_mrt_example.ipynb #60

Closed dulude closed 1 year ago

dulude commented 1 year ago

Relevant Ticket

Summary

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

haticekaratay commented 1 year ago

@alyssaguzman, I fixed the Module Not Found error shown on the executions by upgrading the acstools. It turns out that the module findsat_mrt is only available in later versions of the acstools. However, there is another issue with the notebook. The instructions require users to manually download the files. This process needs to be automated for a successfull execution in the CI which can be done by querying the MAST similar to other notebooks in the hst_notebooks repository. Thanks!