Issue fixes for upcoming release

sosey commented 6 years ago

These are some cumulative updates and issue fixes as I prepare the next release. Specifically they closes #134, closes #132, closes #113, closes #112, and closes #111 which include:

radial profile plot centering changed slightly to use the max brightest pixel after gauss centering
documentation updated and new simple walkthrough added
MEF fits images with IMAGE arrays in the primary HDU should be detected correctly now
now possible to give load_fits an in-memory fits object
code cleanup and minor bug fixes
addition of tests for the util package in association with the above fixes

sosey commented 6 years ago

@rjavila this PR should have the fixes for your drizzle images, give it a go and let me know if you run into any issues.

rjavila commented 6 years ago

@sosey How do I incorporate these changes to my environment? I uninstalled and re-installed. I now have version 0.8.1dev344 but I'm getting the same error as before so I don't think I did the upgrade properly.

sosey commented 6 years ago

from your env, does it show two installs? like this?

conda list imexam
# packages in environment at /Users/sosey/miniconda3/envs/jwstdev:
#
imexam                    0.8.1.dev351              <pip>
imexam                    0.8.0                    py35_1    http://ssb.stsci.edu/astroconda

remove them all:

conda uninstall imexam
pip uninstall imexam

conda list again, and if imexam still shows up uninstall it until it doesn't. Then you can clone the repo from the pr and install. If you already have imexam locally you can make a new remote or you can clone it somewhere else:

# update your imexam directory method
# I'm assuming below you have a remote that points to the spacetelescope/imexam repo called origin
git remote add sosey https://github.com/sosey/imexam.git
git checkout -b test origin/master
git fetch sosey
git rebase sosey/package-fix 
python setup.py install

# If you don't have an imexam clone already
git clone https://github.com/sosey/imexam.git
git submodule update --init -- cextern/xpa
git fetch origin
git checkout -b test origin/master
git rebase origin/package-fix
python setup.py install

lemme know if you run into any issues

coveralls commented 6 years ago

Coverage increased (+1.3%) to 29.079% when pulling e013f429f8896817df71e707252dd649ade892f5 on sosey:package-fix into bb6f1a1a5145e8bf1424477eafa4d37f34dd653c on spacetelescope:master.

sosey commented 6 years ago

@mackjenn I put updates to the radial profile code discussed into this PR, if you install the branch this PR points to you can test them out.

sosey commented 6 years ago

pushing for upcoming hack, still need to update tests

spacetelescope / imexam

Issue fixes for upcoming release #135