search

spacetelescope / imexam

imexam is a python tool for simple image examination, and plotting, with similar functionality to IRAF's imexamine
http://imexam.readthedocs.io
BSD 3-Clause "New" or "Revised" License
74 stars 45 forks source link

Fix compatibility of conftest.py with Astropy 3.2 #177

Closed astrobot closed 5 years ago

astrobot commented 5 years ago

:page_with_curl: About this pull request

Hi there :wave:, it looks like you likely used the astropy package template in the past for your package and we noticed that your conftest.py file is now out of date and imports pytest plugins from astropy:

from astropy.tests.pytest_plugins import *

This astropy sub-package has been removed, so your tests will likely be failing now that astropy v3.2 has been released. This PR therefore fixes this import by checking the astropy version and adjusting the import as needed.

:loudspeaker: For info: updates to the package template

We also wanted to let you know that we have made new releases of the astropy package-template. If your package still needs to support Python 2, you can find the latest Python 2-compatible cookiecutter template here or if you prefer you can find a rendered version of the template here.

If you only need to support Python 3, you can find the latest cookiecutter template here or if you prefer you can find a rendered version of the template here.

If you need any help with updating your package to the latest package template, don't hesitate to ping @astrofrog or @bsipocz and we can try and help.

If you do not want to make this change for now, feel free to close the pull request

Thanks! :robot: :wave:

If there are issues with this pull request, please ping @astrofrog

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.07%) to 28.622% when pulling 20649228eebd47cddacd0e1ea639865fbb807c1f on astrobot:fix-pytest-plugins-import into 65873986d34f56e86199904fa2a5fae63627caa4 on spacetelescope:master.

sosey commented 5 years ago

should be fixed