Closed kecnry closed 1 month ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Sorry I didn't see this one. @gibsongreen, @haticekaratay, can we merge this?
Sorry I didn't see this one. @gibsongreen, @haticekaratay, can we merge this?
It might be overkill but rerunning CI might be worth it. I double checked to make sure the ifu_optimal
notebook will still work (since spectrum_subset1
is in a try-catch, is using this, and gets used again later on in the notebook). The later cell runs as it did before, so no issues there with the update. The other two are in essence prints, so it should be good to merge.
Sorry I didn't see this one. @gibsongreen, @haticekaratay, can we merge this?
It might be overkill but rerunning CI might be worth it. I double checked to make sure the
ifu_optimal
notebook will still work (sincespectrum_subset1
is in a try-catch, is using this, and gets used again later on in the notebook). The later cell runs as it did before, so no issues there with the update. The other two are in essence prints, so it should be good to merge.
Thank you, @gibsongreen, for investigating this. I've checked, and these notebooks run successfully in the main. So, I would only merge if we have a passing CI. Please feel free to rerun the action. I think you already know what's happening, as I haven't looked into that yet. So marking you as the reviewer. 🙏 😃
This PR accompanies https://github.com/spacetelescope/jdaviz/pull/2626 and should only be considered if/when that is both merged and released (EDIT: anytime after jdaviz 3.9 is released). Note that the existing syntax (
viz.app.data_collection
) will continue to work and is not being deprecated, it just isn't intended to be considered as public API.This notebook checklist has been made available to us by the the Notebooks For All team. Its purpose is to serve as a guide for both the notebook author and the technical reviewer highlighting critical aspects to consider when striving to develop an accessible and effective notebook.
The First Cell
<h1>
or# in markdown
).1., 2.,
etc. in Markdown).The Rest of the Cells
#
in Markdown) used in the notebook.Text
Code
Images
[ ] All images (jpg, png, svgs) have an image description. This could be
alt
property)alt
attribute with no value)[ ] Any text present in images exists in a text form outside of the image (this can be alt text, captions, or surrounding text.)
Visualizations
[ ] All visualizations have an image description. Review the previous section, Images, for more information on how to add it.
[ ] Visualization descriptions include
[ ] All visualizations and their parts have enough color contrast (color contrast checker) to be legible. Remember that transparent colors have lower contrast than their opaque versions.
[ ] All visualizations convey information with more visual cues than color coding. Use text labels, patterns, or icons alongside color to achieve this.
[ ] All visualizations have an additional way for notebook readers to access the information. Linking to the original data, including a table of the data in the same notebook, or sonifying the plot are all options.