spacetelescope / jdat_notebooks

JWST Data Analysis Tools Notebooks
https://spacetelescope.github.io/jdat_notebooks/
98 stars 80 forks source link

Add NIRISS WFSS Notebook Examples #214

Closed Rplesha closed 4 weeks ago

Rplesha commented 5 months ago

This notebook checklist has been made available to us by the the Notebooks For All team. Its purpose is to serve as a guide for both the notebook author and the technical reviewer highlighting critical aspects to consider when striving to develop an accessible and effective notebook.

The First Cell

The Rest of the Cells

Text

Code

Images

Visualizations

for review; I would like comments on this

review-notebook-app[bot] commented 5 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Rplesha commented 5 months ago

This is being reviewed by members of the NIRISS team and @camipacifici before it will be ready to be merged.

camipacifici commented 4 months ago

I talked to the CI folks and got the confirmation that each notebook runs individually, so notebook 01 cannot use the output of notebook 00. Same deal for notebook 02. Can you please store on box the outputs of notebook 00 and 01 so that notebooks 01 and 02 can grab them? I sent you an invite to the box folder. Feel free to create a new folder for this set.

Rplesha commented 4 months ago

I've added the data files to the box folder niriss_wfss_advanced, and then they are separated in there by notebook. The notebooks expect the data in a specific directory though, not necessarily just the top level directory. Does the box folder need to match that structure to work properly?

camipacifici commented 4 months ago

I've added the data files to the box folder niriss_wfss_advanced, and then they are separated in there by notebook. The notebooks expect the data in a specific directory though, not necessarily just the top level directory. Does the box folder need to match that structure to work properly?

Hum...I think you have to use whatever makes sense when you download in the individual notebook. Each notebook should only pull the data it needs, not everything. Maybe I am not understanding the question, sorry.

Rplesha commented 4 months ago

I've added the data files to the box folder niriss_wfss_advanced, and then they are separated in there by notebook. The notebooks expect the data in a specific directory though, not necessarily just the top level directory. Does the box folder need to match that structure to work properly?

Hum...I think you have to use whatever makes sense when you download in the individual notebook. Each notebook should only pull the data it needs, not everything. Maybe I am not understanding the question, sorry.

@camipacifici Right now all of the data are in a single directory for each notebook. However, to run the cells, the notebooks expect that data to be in certain folders, which they're not on box. Do I need to mimic the folder structure that the notebooks expect, or is it fine that the data are just in a single level folder?

camipacifici commented 4 months ago

@Rplesha either you recreate the expected structure on box, or you rearrange the files as they need to be after you download them from the notebook. the important thing is to keep the notebooks independent (they can run without having run the one before) and light (so download only the files the notebook needs). thanks!!

mgough-970 commented 3 months ago

Sorry about the spam, I had to update the workflow a bit.
Additionally, all notebooks require a requirements file, these notebooks will fail until one is provided in the notebooks directory.

Rplesha commented 3 months ago

Thanks @mgough-970 ! I was actually just working to make a requirements file now.

camipacifici commented 3 months ago

Thank you for all the edits, @Rplesha!! Whenever you are ready, just put it out of draft and we'll have it go through technical review.

Rplesha commented 2 months ago

@camipacifici this is ready for review now whenever there is time

camipacifici commented 1 month ago

This is great! Thank you!