spacetelescope / jdat_notebooks

JWST Data Analysis Tools Notebooks
https://spacetelescope.github.io/jdat_notebooks/
98 stars 80 forks source link

add NIRISS imaging pipeline tutorial notebook #215

Closed gibsongreen closed 3 months ago

gibsongreen commented 4 months ago

This notebook checklist has been made available to us by the the Notebooks For All team. Its purpose is to serve as a guide for both the notebook author and the technical reviewer highlighting critical aspects to consider when striving to develop an accessible and effective notebook.

The First Cell

The Rest of the Cells

Text

Code

Images

Visualizations

review-notebook-app[bot] commented 4 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

gibsongreen commented 4 months ago

@mgough-970 This notebook's Execution/Validation CI is timing out with the 2000 second limit. I reached out to Hatice before this comment and she had let me know it's been a known issue and suggested I reach out to you to see if there have been any updates or work arounds.

Notebook cell execution failed
Cell 6: Timeout of 2000 seconds exceeded executing cell

After this is resolved, I'll make sure to take into account your last comment on #212 and follow a similar path with this PR.

camipacifici commented 3 months ago

Thank you @mgough-970 for fixing this! @gibsongreen I think this is ready to go in now.

gibsongreen commented 3 months ago

Thank you @mgough-970 for fixing this! @gibsongreen I think this is ready to go in now.

Thank you @mgough-970 !!!