Open Jdaviz-Triage-Bot opened 1 year ago
I tried tweaking add_markers
logic but nothing worked. Perhaps this is deeper upstream, maybe should ask SMEs.
This is bqplot-image-gl : https://github.com/glue-viz/bqplot-image-gl/blob/master/js/lib/imagegl.js
which means the image gets fed the wrong type of data.
How can this be reproduced?
How can this be reproduced?
Run the https://github.com/spacetelescope/jdaviz/blob/main/notebooks/ImvizExample.ipynb and you will see it pop up during add_markers
step.
add_markers
is basically linking table to image. I got that code from an old glue-jupyter example at https://github.com/glue-viz/glue-jupyter/blob/main/notebooks/Astronomy/W5/W5%20Tutorial.ipynb
IOPub message rate exceeded. The notebook server will temporarily stop sending output to the client in order to avoid crashing it. To change this limit, set the config variable
--NotebookApp.iopub_msg_rate_limit
.Current values: NotebookApp.iopub_msg_rate_limit=1000.0 (msgs/sec) NotebookApp.rate_limit_window=3.0 (secs)
I've also seen this, and what I see happening is.
What I have seen, is that two updates had the same update data, meaning that add_global_callback
was triggered even when no data was changed. This could be a feature or a bug of echo
(question for @astrofrog)
I think this will be partially fixed by https://github.com/glue-viz/glue-jupyter/pull/325 - can someone check?
This was closed accidentally by https://github.com/glue-viz/glue-jupyter/pull/324 which only addressed one of the issues here
I'll check after lunch break. Thanks for the quick fixes!
@astrofrog I looked at the number of messages between the front and back ends when running the cell to add markers in the ImvizExample notebook, and it looks like it went from ~900 messages before your glue-jupyter
PR to ~250 after, so I'd call that a success.
Nice, can I ask how you counted that? I didn't see any message counter in chrome's dev console. 250 is still quite large, is that the 99.9/100.0% trick we're seeing?
I just looked at the Response tab for the channel in Firefox. Number of messages is below the last red arrow in the screenshot (note that I accidentally moused over the image here and added 70 extra messages, the number for the marker cell was ~200).
Edit: This also seems to have cut the execution time a bit for that cell (adding markers). It's consistently ~900-1000 ms on glue-jupyter
main, and ~50-75% of that (490-700 ms) with Tom's PR. Not rigorous benchmarking, just tried it a few times with each.
More notes at https://github.com/spacetelescope/jdaviz/issues/1664#issuecomment-1274821528
Reporter: pllim
Run the Imviz example notebook up to the point of
viewer.add_markers()
call. See screenshot.Update: The red screenshot went away with https://github.com/glue-viz/glue-jupyter/pull/324
Maybe the table needs to be sanitized before being passed into glue.
Sometimes I also see this but not sure if it is related or a different problem:
Update: IOPub problem might have been addressed by https://github.com/glue-viz/glue-jupyter/pull/325
This is a more specific case than #1367 .
🐱
DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter. If any information is incorrect, please contact Duy Nguyen