spacetelescope / jdaviz

JWST astronomical data analysis tools in the Jupyter platform
https://jdaviz.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
134 stars 72 forks source link

Aperture photometry table: save also background method and parameters #2036

Open Jdaviz-Triage-Bot opened 1 year ago

Jdaviz-Triage-Bot commented 1 year ago

Reporter: Camilla Pacifici

I used aperture photometry on a set of regions using 2 different background settings and I found myself wanting to know what type of background I used to better understand the results and decide which set was better, but that information was lost when calling get_aperture_photometry_results().

🐱


DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter. If any information is incorrect, please contact Duy Nguyen

pllim commented 1 year ago

https://jdaviz.readthedocs.io/en/latest/imviz/plugins.html#simple-aperture-photometry

There are 3 ways one can define a background:

  1. Manually entering a float value.
  2. Circular annulus around subset (user can set inner and outer radii).
  3. Another subset (any supported shapes).

To log the type of background is a matter of adding one additional column named, say, bg_method. However, that does not guarantee reproducibility. If reproducibility is your goal, we need to think more because it is hard to serialize so many different ways to calculate background in a table with fixed columns.

While we're discussing this, the current exported table also does not have sufficient information for you to reproduce the aperture. It logs the center, total area, and name but not the shape of aperture subset.