search

spacetelescope / jdaviz

JWST astronomical data analysis tools in the Jupyter platform
https://jdaviz.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
136 stars 73 forks source link

Make FootprintOverlay more flexible/generic #2455

Open Jdaviz-Triage-Bot opened 1 year ago

Jdaviz-Triage-Bot commented 1 year ago

Reporter: pllim

FootprintOverlay mark object was added for FootPrints plugin only in mind. But I found it very useful for generic polygon overlay directly in bqplot layer (e.g., in https://github.com/spacetelescope/jdaviz/pull/2410).

Two suggestions:

  1. Generalize its implementation so that Imviz won't break if the object is used outside of Footprints plugin.
  2. See if we can cache the original Region object as an attribute in this object directly. This would make it unnecessary to catch it separately in places that uses FootprintOverlay. Original Region object needs to be stored for roundtripping because everything gets converted into polygon pixel regions for bqplot. This is only feasible if we can make sure this attached Region object will not get sent to the frontend.

Since @kecnry originally implemented this, he should be at least consulted if he is not doing this work directly.

🐱

DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter.

stscijgbot-jwql commented 2 months ago

This issue is tracked on JIRA as JDAT-3804.

stscijgbot-jwql commented 2 months ago

Comment by Kyle Conroy on JIRA:

NOTICE: A corresponding GitHub issue was automatically created: #2455