spacetelescope / jdaviz

JWST astronomical data analysis tools in the Jupyter platform
https://jdaviz.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
129 stars 67 forks source link

[BUG] Can't type in VMIN and VMAX values for the stretch #2723

Open hcferguson opened 5 months ago

hcferguson commented 5 months ago

Jdaviz component

Imviz

Description

Running jdaviz --layout jdaviz on the safari browser (version jdaviz-3.8.1.dev276+g808b8970) -- when I try to set the VMIN and VMAX values of the stretch it just wants to set them to integers. I can use the up and down arrows or grab the line on the histogram, but that's tedious.

How to Reproduce

  1. Get package from '...'
  2. Then run '...'
  3. An error occurs.

Expected behavior

Should let me type in the VMIN and VMAX values

Browser

Safari

Jupyter

jupyter --version

Software versions

import platform; print(platform.platform()) import sys; print("Python", sys.version) import numpy; print("Numpy", numpy.version) import astropy; print("astropy", astropy.version) import matplotlib; print("matplotlib", matplotlib.version) import scipy; print("scipy", scipy.version) import skimage; print("scikit-image", skimage.version) import asdf; print("asdf", asdf.version) import stdatamodels; print("stdatamodels", stdatamodels.version) import gwcs; print("gwcs", gwcs.version) import regions; print("regions", regions.version) import specutils; print("specutils", specutils.version) import specreduce; print("specreduce", specreduce.version) import photutils; print("photutils", photutils.version) import astroquery; print("astroquery", astroquery.version) import yaml; print("pyyaml", yaml.version) import asteval; print("asteval", asteval.version) import idna; print("idna", idna.version) import traitlets; print("traitlets", traitlets.version) import bqplot; print("bqplot", bqplot.version) import bqplot_image_gl; print("bqplot-image-gl", bqplot_image_gl.version) import glue; print("glue-core", glue.version) import glue_jupyter; print("glue-jupyter", glue_jupyter.version) import glue_astronomy; print("glue-astronomy", glue_astronomy.version) import echo; print("echo", echo.version) import ipyvue; print("ipyvue", ipyvue.version) import ipyvuetify; print("ipyvuetify", ipyvuetify.version) import ipysplitpanes; print("ipysplitpanes", ipysplitpanes.version) import ipygoldenlayout; print("ipygoldenlayout", ipygoldenlayout.version) import ipypopout; print("ipypopout", ipypopout.version) import jinja2; print("Jinja2", jinja2.version) import voila; print("voila", voila.version) import vispy; print("vispy", vispy.version) import sidecar; print("sidecar", sidecar.version) import jdaviz; print("Jdaviz", jdaviz.version)

kecnry commented 5 months ago

You're trying to set the values from the inputs in the plot options plugin? If that's the case - the widget step size is determined dynamically, can you provide the output from imviz.plugins['Plot Options']._obj.stretch_vstep (you'll need to run in a notebook or lab for this... if that's a big hassle, no worries)? The widget still should allow giving more precision though, that should only affect the +/- buttons.

kecnry commented 5 months ago

I can't reproduce on my end - if you can provide either a screen recording or the data you're using, that would also be helpful in tracking down what's going on.

pllim commented 4 months ago

@hcferguson , does it work when you use Chrome instead of Safari to run Jdaviz?