Closed pllim closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.89%. Comparing base (
5a020cc
) to head (b80fb8a
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@havok2063 , would this work for your use case? Can you please try it out? Thanks!
Rebased to get rid of merge conflicts.
Thanks for the reviews!
Description
This pull request is to fix loading MANGA cube in Cubeviz. Since Brian C said it works on Jdaviz 3.10 series, probably no need to backport.
This supersedes #3115 and takes advantage of the loaders that already exist in
specutils
when we can, like Brian Cherinka suggested. Also convert uncert type to stddev when we can, like Brett Morris suggested.I tried to get rid of
_parse_hdulist
altogether but too many tests failed, so I kept it as a fallback.Also fixed a Marker display bug where wavelength shows as
0.000 m
, which is very uninformative.Change log entry
CHANGES.rst
? If you want to avoid merge conflicts, list the proposed change log here for review and add toCHANGES.rst
before merge. If no, maintainer should add ano-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.