spacetelescope / jdaviz

JWST astronomical data analysis tools in the Jupyter platform
https://jdaviz.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
138 stars 73 forks source link

Fix cube fit toggle with spectral subset selected #3123

Closed rosteen closed 2 months ago

rosteen commented 2 months ago

This fixes a bug where toggling to Cube Fit in the model fitting plugin when a spectral subset was selected would result in a traceback and no data being available in the dataset menu. It appears that the dataset is briefly set to None in this case before the appropriate cube data is populated in the menu.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.88%. Comparing base (a126296) to head (3ed6a64). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3123 +/- ## ========================================== - Coverage 88.93% 88.88% -0.06% ========================================== Files 112 112 Lines 17411 17391 -20 ========================================== - Hits 15485 15458 -27 - Misses 1926 1933 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.