Backport PR #3123 on branch v3.10.x (Fix cube fit toggle with spectral subset selected)

spacetelescope / jdaviz

JWST astronomical data analysis tools in the Jupyter platform

https://jdaviz.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

138 stars 73 forks source link

Backport PR #3123 on branch v3.10.x (Fix cube fit toggle with spectral subset selected) #3125

Closed meeseeksmachine closed 2 months ago

meeseeksmachine commented 2 months ago

Backport PR #3123: Fix cube fit toggle with spectral subset selected

kecnry commented 2 months ago

I should have paid more attention during the original PR - is this confirmed as a bug in 3.10 and not just main?

kecnry commented 2 months ago

The behavior for the cube toggle was changed in https://github.com/spacetelescope/jdaviz/pull/2827 which is milestoned as 4.0, so even though the diff seems to be able to backport, I'm not sure that the bug was present until then 🤔

rosteen commented 2 months ago

I'll double check.

rosteen commented 2 months ago

You're right, I milestoned that PR incorrectly. I'll close this and open a quick PR to move the changelog entry.