Closed rosteen closed 1 month ago
Does any of this overlap or conflict with #3116? (cc @bmorris3)
Whoops, it almost certainly does. I should have stuck to fixing the first bug I found 😆
I could split out the changes to coords_info.py
, @bmorris3 should check this to make sure I was actually fixing the same things, if I wasn't the other changes can stay.
Alright, after talking with @bmorris3 offline I dropped the stuff that overlapped with #3116 and kept the fix to the mouseover for things in incompatible units like velocity.
There is a conflict. Please rebase.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.42%. Comparing base (
a9b559b
) to head (535727f
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks like #3139 broke adding moment maps to a viewer, due to the
coords_info
logic. This skips the flux conversion that breaks it in the case of moment-like units (velocity and higher powers of it) by skipping any unit with incompatible physical type.~Additionally, calculating moment 0 in flux when the cube is in surface brightness seemed to be broken (again?) so I moved the unit conversion to be before the moment calculation, so we can convert, e.g., MJy/sr to MJy and not have to worry about the extra wavelength unit that comes in via the moment calculation.~
~I also took this opportunity to bump the specutils pin and get rid of the handling for the change in 1.16 for the dev tests and such.~