spacetelescope / jdaviz

JWST astronomical data analysis tools in the Jupyter platform
https://jdaviz.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
138 stars 73 forks source link

Fix for NIRSpec IRS2 readout mode #3167

Closed bmorris3 closed 1 month ago

bmorris3 commented 1 month ago

Description

3148 implemented parsers for JWST ramp cubes. JWST/NIRSpec has two readout modes, and it appears that the IRS2 readout modes produce ramp cubes with the order of the x and y axes swapped. This PR identifies that special case and rearranges the axes correctly.

Test this PR with:

from jdaviz import Rampviz

uri = "mast:JWST/product/jw02123001002_0310d_00001_nrs1_uncal.fits"

rampviz = Rampviz()
rampviz.load_data(uri, cache=True)
rampviz.show()

Change log entry

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.41%. Comparing base (a9b559b) to head (0e735d5). Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
jdaviz/configs/rampviz/plugins/parsers.py 69.23% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3167 +/- ## ========================================== - Coverage 88.42% 88.41% -0.01% ========================================== Files 122 122 Lines 18264 18272 +8 ========================================== + Hits 16150 16156 +6 - Misses 2114 2116 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.