spacetelescope / jdaviz

JWST astronomical data analysis tools in the Jupyter platform
https://jdaviz.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
138 stars 73 forks source link

BUG: Fix wrong Subset unit when created in 2D spectrum viewer #3201

Closed pllim closed 3 days ago

pllim commented 1 week ago

Description

This pull request is to address wrong Subset unit when it is extracted from Subset created in Specviz2d on the 2D spectrum viewer. Glue itself does not attach unit natively to Subset, so that means Jdaviz made wrong assumptions in the extraction code. Bug ticket blamed it to the Export plugin but the actual bug has nothing to do with the Export plugin, thought the plugin did expose the bug when user extracted Subset that way but you don't need the plugin to reproduce the bug.

Change log entry

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.44%. Comparing base (f880d55) to head (eafb391). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
jdaviz/app.py 66.66% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3201 +/- ## ========================================== - Coverage 88.46% 88.44% -0.02% ========================================== Files 125 125 Lines 18668 18676 +8 ========================================== + Hits 16514 16518 +4 - Misses 2154 2158 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pllim commented 4 days ago

@kecnry , I think I addressed your comment.

pllim commented 3 days ago

Actually I am not going to backport this because it is unlikely the backport will be clean due to unit conversion stuff.

pllim commented 3 days ago

Thanks, all!