Closed pllim closed 3 days ago
Attention: Patch coverage is 66.66667%
with 5 lines
in your changes missing coverage. Please review.
Project coverage is 88.44%. Comparing base (
f880d55
) to head (eafb391
). Report is 2 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
jdaviz/app.py | 66.66% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@kecnry , I think I addressed your comment.
Actually I am not going to backport this because it is unlikely the backport will be clean due to unit conversion stuff.
Thanks, all!
Description
This pull request is to address wrong Subset unit when it is extracted from Subset created in Specviz2d on the 2D spectrum viewer. Glue itself does not attach unit natively to Subset, so that means Jdaviz made wrong assumptions in the extraction code. Bug ticket blamed it to the Export plugin but the actual bug has nothing to do with the Export plugin, thought the plugin did expose the bug when user extracted Subset that way but you don't need the plugin to reproduce the bug.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts, list the proposed change log here for review and add toCHANGES.rst
before merge. If no, maintainer should add ano-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.