spacetelescope / jdaviz

JWST astronomical data analysis tools in the Jupyter platform
https://jdaviz.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
142 stars 74 forks source link

[BUG] Specviz: plot Y axis labels are confusing (switch from e to g formatting) #960

Open karlglazebrook opened 3 years ago

karlglazebrook commented 3 years ago

Describe the bug The plot Y axis labels are truncated, meaning the values are not possible to discern, when they include exponential notation.

To Reproduce Steps to reproduce the behavior:

Run the notebook at https://github.com/spacetelescope/jwebbinar_prep/blob/main/jdat_session/Specutils_Webbinar_solutions.ipynb

Expected behavior Needs to show all digits of Y axis label exponent

Screenshots

image

(see left Y axis)

Desktop (please complete the following information):

Package versions (please complete the following information):

Linux-5.10.47-linuxkit-x86_64-with-glibc2.29 Python 3.8.10 (default, Sep 28 2021, 16:10:42) [GCC 9.3.0] Numpy 1.21.3 astropy 4.3.1 specutils 1.4.2.dev37+gd7507aa2 spectral-cube 0.6.0 pyyaml 6.0 click 8.0.3 asteval 0.9.25 idna 2.10 traitlets 5.1.1 bqplot 0.12.31 bqplot-image-gl 1.4.4 glue-core 1.2.2 glue-jupyter 0.10.1 glue-astronomy 0.3.2 echo 0.5 ipyvue 1.7.0 ipyvuetify 1.8.1 ipysplitpanes 0.2.0 ipygoldenlayout 0.4.0 voila 0.2.16

Additional context (e.g. data files)

🐱

pllim commented 3 years ago

I am not sure if they are truncated, rather than just rendering 1.0 as 1.0e+0. This formatting was implemented in #865.

For example:

>>> print(f"{1:0.1e}")
1.0e+00
karlglazebrook commented 3 years ago

Since e0 = 1 it should simply be omitted. Probably change to g format to switch automatically

Note if I see e+0 I then expect there to be a second digit, hence the report.

Karl

On 10 Nov 2021, at 5:31 am, P. L. Lim @.***> wrote:

 I am not sure if they are truncated, rather than just rendering 1.0 as 1.0e+0. This formatting was implemented in #865.

For example:

print(f"{1:0.1e}") 1.0e+00 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.