spacetelescope / jwql

The James Webb Space Telescope Quicklook Application
BSD 3-Clause "New" or "Revised" License
64 stars 43 forks source link

Look into pytest-django #1232

Open bhilbert4 opened 1 year ago

bhilbert4 commented 1 year ago

Look into using pytest-django to allow us to run tests involving the django models. We currently skip these tests on github actions since they have no access to the models.

bhilbert4 commented 1 year ago

This seems like something we don't need to worry about if we're going to move from Django models to postgres, right? @BradleySappington are we going to keep any Django models after the transition?

BradleySappington commented 1 year ago

This is still relevant as we are still going to continue using Django Models. The models are currently created (for us by django) as tables in sqlite. In order to get them to fulfill our needs we will need to update the Django Models to be stored in tables using a postgres db.

bhilbert4 commented 1 year ago

Ah I see. I had been assuming we were going to move everything to postgres tables and access similarly to how we do the monitor database tables. Thanks for setting me straight!

bhilbert4 commented 6 months ago

@BradleySappington is this now even more relevant than before since we have everything in Django models now?

BradleySappington commented 6 months ago

yup! We need to make sure we are testing all of these models