spacetelescope / jwql

The James Webb Space Telescope Quicklook Application
BSD 3-Clause "New" or "Revised" License
64 stars 42 forks source link

show file anomalies on exposure group page #1564

Closed BradleySappington closed 2 months ago

BradleySappington commented 2 months ago

When viewing groups of exposures, show table of anomalies for each file. Update how tables get populated to allow for dynamic setting of column pairs.

pep8speaks commented 2 months ago

Hello @BradleySappington, Thank you for updating !

Cheers ! There are no PEP8 issues in this Pull Request. :beers:

Comment last updated at 2024-05-07 16:29:57 UTC
BradleySappington commented 2 months ago
Screenshot 2024-05-07 at 10 56 16 AM
BradleySappington commented 2 months ago

@bhilbert4 , I updated your table maker to designate the table id (so multiple tables per page can use it), and to take a user defined "nr_paired_columns" parameter. So we can use that for any shape table that has key/value combo moving forward

bhilbert4 commented 2 months ago

Nice! Looks good. Have you tested on a NIRCam group that has 10 detectors?

mfixstsci commented 2 months ago

@BradleySappington this looks great! I am curious along with @bhilbert4 about how that would look. @bhilbert4 do you know of an example off of the top of your head that will have a large number of detectors that Brad could test on?

bhilbert4 commented 2 months ago

Looks like jw01022099001_03101_00001 should have all 10 nircam detectors, when running locally.

mfixstsci commented 2 months ago

Looks like jw01022099001_03101_00001 should have all 10 nircam detectors, when running locally.

Thank you 🙏

BradleySappington commented 2 months ago

@mfixstsci and @bhilbert4 Here ya go!

Screenshot 2024-05-07 at 11 55 46 AM
mfixstsci commented 2 months ago

@mfixstsci and @bhilbert4 Here ya go!

Screenshot 2024-05-07 at 11 55 46 AM

oh yeah, this rocks. I approve 👍

bhilbert4 commented 2 months ago

Yeah, looks good!

BradleySappington commented 2 months ago

awesome, thanks! I'll merge once its approved

mfixstsci commented 2 months ago

awesome, thanks! I'll merge once its approved

Send it when you are ready @BradleySappington