search

spacetelescope / jwql

The James Webb Space Telescope Quicklook Application
BSD 3-Clause "New" or "Revised" License
64 stars 43 forks source link

Update bokeh.figure.plotting.circle calls to use radius keyword #1632

Open stscijgbot-jwql opened 2 months ago

stscijgbot-jwql commented 2 months ago

Issue JWQL-250 was created on JIRA by Bryan Hilbert:

Starting with Bokeh 3.4 the circle plotting function requires either the "size" or "radius" keyword to be included in calls. If neither is specified, Bokeh returns a blank plot because they do not define a default value for these keywords.

Note that use of "size" is already deprecated and will be removed in an upcoming Bokeh release, so we should make sure we're using "radius" in all calls. 

A quick search of the codebase shows calls to the circle plotting function in:

bokeh_dashboard.py

engineering_database.py

bokeh_containers.py

monitor_bad_pixel_bokeh.py

dark_monitor.py

edb_telemetry_monitor.py

along with a handful of bokeh-templating related files that we can ignore.

stscijgbot-jwql commented 2 months ago

Comment by Bryan Hilbert on JIRA:

Fix in #1643