spacetelescope / jwql

The James Webb Space Telescope Quicklook Application
BSD 3-Clause "New" or "Revised" License
64 stars 43 forks source link

object-level files for WFSS being shown in JWQL #1650

Open stscijgbot-jwql opened 1 week ago

stscijgbot-jwql commented 1 week ago

Issue JWQL-254 was created on JIRA by Bryan Hilbert:

Somehow, only for WFSS that I've seen so far, object-specific files are now showing up on the observation level pages. e.g. https://jwql.stsci.edu/NIRCam/archive/2279/obs001/ and https://jwql.stsci.edu/NIRISS/archive/1208/obs002/  The empty thumbnails are for files such as https://jwql.stsci.edu/NIRISS/exposure/jw01208-c1008_s000000170_n/ or https://jwql.stsci.edu/NIRCam/exposure/jw02279-o001_s000000543_ni/ 

Clearly these are (truncated) names that used to be filtered out somewhere in the process, but are no longer. We need to find out how these are getting through and stop them. 

stscijgbot-jwql commented 1 week ago

Comment by Bryan Hilbert on JIRA:

I think the issue is here: https://github.com/spacetelescope/jwql/blob/develop/jwql/website/apps/jwql/data_containers.py#L2206

 

get_filenames_by_intstrument() returns a list of filenames that include things like jw02279-o001_s000000035_nircam_f444w-grismr. Then, each filename is passed through the filename_parser. Those that fail, for some reason, use a set of assumed values in the file info dictionary that is being constructed.  I'm not sure why those files are kept at all. Seems like we would want to simply skip the file. But maybe this will throw off the length of various varibles, where the assumption is one value per file? Looks like this code has been in place for a while, so not a recent mistake....

stscijgbot-jwql commented 1 week ago

Comment by Bryan Hilbert on JIRA:

Beginnings of a fix here: #1651