search

spacetelescope / jwst-pipeline-notebooks

JWST Calibration Pipeline Notebooks
https://spacetelescope.github.io/jwst-pipeline-notebooks/
Other
2 stars 14 forks source link

FInal version of NIRISS Imaging with new name #17

Closed rizeladiaz closed 1 month ago

rizeladiaz commented 1 month ago

Changes to Notebook: ———————————————————

  1. Notebook chaged name to match format
  2. changed the requirement files to set numpy <2.0 and remove CRDS call from there. Changed version of the pipieline to run 1.14.0
  3. Added author field.
  4. NIRISS Team reviewed Recent Changes section
  5. Added section to configure CRDS
  6. Changed the organization to agree with that of the template notebook. Mainly move the import packages after configuration of CRDS.
  7. Added demo mode to import from astroquery
  8. Moved information about restricting data to one filter to the section talking about getting the data from MAST
  9. Removed sections for getting the data from Box and added sections to get the data from MAST in demo mode
  10. Added section to set the directories as the MRS notebook
  11. Removed mention of WFSS and AMI because these do not apply to this notebook.
  12. Removed section about read-the-docs pipeline documentation as it repeats what is provided in JDox and could become out of sync.
  13. Added time benchmark counters for all stages. NIRISS changed them to be integer seconds.
  14. NIRISS team changed the way the reference files are printed to a separate cell
  15. Added In Detector 1 a new section to define a dictionary with the steps that run and examples of how to override parameters or reference files via a dictionary.
  16. Added dictionary and parameters for Image 2
  17. NIRISS team did check the parameters for Image2 run
  18. Added dictionary and parameters for Image 3
  19. NIRISS team did check parameters for Image3 run
  20. Moved to save the association Image3 file in the ObsXXX directory and changed cal files get the full path rather than relative paths (which was crashing the run).
  21. Moved plotting or data visualization to the end
review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

drlaw1558 commented 1 month ago

Hm, I'm puzzled. It looks like the notebook on this branch to be merged was last edited 27 days ago, but I know @slamassa 's version was updated within the last 2-3 days. Looking at the commit history, I think Steph's edits were merged into Rossy's main branch, while this PR is trying to merge from Rossy's NIRISS-imaging-diaz branch.

rizeladiaz commented 1 month ago

Thanks for noticing David. That is not what I wanted to do! Let me do this again and make sure that it pushing the right version. Apologies