stscijgbot
commented
4 years ago Comment by Howard Bushouse: Sorry, my mistake. It's not actually being saved twice, because the "save_results" param for the white_light step is not turned on, hence the step itself is not trying to save it. It's just being saved by the calwebb_tso3 pipeline module, but in the example being tested the output file already existed from a previous run and hence the warning about using "overwrite" was issued. So the only change needed is to use the "overwrite" argument when the file is saved from calwebb_tso3.
Issue JP-1250 was created by Howard Bushouse:
The calwebb_tso3 pipeline always issues the warning: {code:java} 2020-01-29 09:56:04,689 - stpipe.Tso3Pipeline.white_light - INFO - Step white_light running with args (,).
2020-01-29 09:56:04,690 - stpipe.Tso3Pipeline.white_light - INFO - Step white_light parameters are: {'pre_hooks': [], 'post_hooks': [], 'output_file': None, 'output_dir': None, 'output_ext': '.ecsv', 'output_use_model': False, 'output_use_index': True, 'save_results': False, 'skip': False, 'suffix': 'whtlt', 'search_output_file': True, 'input_dir': ''}
2020-01-29 09:56:04,699 - stpipe.Tso3Pipeline.white_light - DEBUG - norders = 1, sporders = [1], ntables_order = [10]
2020-01-29 09:56:04,701 - stpipe.Tso3Pipeline.white_light - WARNING - There is no INT_TIMES table in the input file.
2020-01-29 09:56:04,701 - stpipe.Tso3Pipeline.white_light - DEBUG - Times were computed from EXPSTART and TGROUP.
2020-01-29 09:56:04,702 - stpipe.Tso3Pipeline.white_light - INFO - Step white_light done
2020-01-29 09:56:08,132 - stpipe.Tso3Pipeline - INFO - Saved model in grism_tso_f444w_x1dints.fits
2020-01-29 09:56:08,134 - stpipe.Tso3Pipeline - WARNING - /Users/bushouse/anaconda3/envs/jwstdev/lib/python3.7/site-packages/astropy/utils/metadata.py:360: MergeConflictWarning: Cannot merge meta key 'number_of_integrations' types <class 'int'> and <class 'int'>, choosing number_of_integrations=10
MergeConflictWarning)
2020-01-29 09:56:08,134 - stpipe.Tso3Pipeline - INFO - Writing Level 3 photometry catalog grism_tso_f444w_whtlt.ecsv... 2020-01-29 09:56:08,138 - stpipe.Tso3Pipeline - WARNING - /Users/bushouse/anaconda3/envs/jwstdev/lib/python3.7/site-packages/astropy/io/ascii/ui.py:750: AstropyDeprecationWarning: grism_tso_f444w_whtlt.ecsv already exists. Automatically overwriting ASCII files is deprecated. Use the argument 'overwrite=True' in the future. output), AstropyDeprecationWarning)
2020-01-29 09:56:08,148 - stpipe.Tso3Pipeline - INFO - Step Tso3Pipeline done {code} despite the fact that the "overwrite" argument is set when the
white_lightstep saves the file (inwhite_light_step.py).This is due to the fact that the
calwebb_tso3pipeline module is also saving the photometric catalog return from the step. It's the second attempt to save the file that's generating the warning, because that call does not include the "overwrite" argument.Need to have the file saved only once, either by the step or the pipeline module.