spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope

https://jwst-pipeline.readthedocs.io/en/latest/

Other

558 stars 164 forks source link

Outlier Detection validation testing #5065

Closed stscijgbot-jp closed 3 years ago

stscijgbot-jp commented 4 years ago

Issue JP-1528 was created on JIRA by Alicia Canipe:

outlier_detection

Updated step arguments in the documentation. [#⁠4723]
Change outlier and resample DQ bit usage. [#⁠4726] Default value of good_bits now includes all DQ flags except DO_NOT_USE. Also, newly flagged outliers are flagged with DO_NOT_USE + OUTLIER.
Added a hardcoded declaration of a reasonable scale parameter for MIRI MRS as a stopgap measure until a parameter reference file can pass one more cleanly. [#⁠4778]

The updates above were made to the outlier_detection step of the level-3 pipelines. Perform validation tests for your instrument to check that the step is working for all modes and configurations, and that it is performing as expected according to the algorithm defined by the CalWG.

stscijgbot-jp commented 4 years ago

Comment by Nestor Espinoza on JIRA:

Testing was performed on this step for TSO3 with NIRISS/SOSS simulations (see https://jira.stsci.edu/browse/NIRISS-182). Found some issues, summarized in the following tickets:

JP-1647).

The algorithm is detecting outliers based on the geometrical properties of the NIRISS/SOSS profiles (bug ticket: https://jira.stsci.edu/browse/JP-1654).

The algorithm is not using TSO information at all for spectroscopic TSOs, which is producing weird patterns in the detected outliers which depend on the astrophysical signal present in the data (improvement ticket: https://jira.stsci.edu/browse/JP-1655).

stscijgbot-jp commented 3 years ago

Comment by Rachel Cooper on JIRA:

Testing for the Image3 outlier detection was done on integrations of a NIRISS imaging scene simulated with MIRAGE. Details are recorded at https://jira.stsci.edu/browse/NIRISS-153

The step flagged considerable numbers of outliers other than those intentionally inserted for the testing. We tested how many outliers were flagged by the running the step with varying SNR arguments; the results can be found here: https://jira.stsci.edu/browse/NIRISS-155

stscijgbot-jp commented 3 years ago

Comment by Alicia Canipe on JIRA:

Build 7.5 testing is complete. Closing the related issues in preparation for Build 7.6 testing.