search

spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
569 stars 167 forks source link

Investigate using astropy in MRS residual fringe correction code #6222

Open stscijgbot-jp opened 3 years ago

stscijgbot-jp commented 3 years ago

Issue JP-2205 was created on JIRA by Nadia Dencheva:

JP-1273 implements a residual fringe correction for MRS.

It uses a third party modeling library. To minimize the number of dependencies and libraries we need to understand/maintain if possible it should be replaced with astropy.modeling.

stscijgbot-jp commented 1 year ago

Comment by David Law on JIRA:

This ticket and https://jira.stsci.edu/browse/JP-2344 are both pretty outdated at this point, as the refactor appears to have stalled.

stscijgbot-jp commented 7 months ago

Comment by David Law on JIRA:

Nadia Dencheva Do you know if any work is still taking place on this?  I think it got partially finished, but not entirely so, which would make it another long-term technical debt ticket.

stscijgbot-jp commented 7 months ago

Comment by Nadia Dencheva on JIRA:

There's no work going on at the moment. My recollection is the team was not very happy with the algorithm and or implementation. In addition it seems the third party software used by the pipeline code is not maintained any more. This should be revisited when the right resources are available and should probably be put on hold for now or closed.

jemorrison commented 7 months ago

As I remember there were small differences between the pipeline results and the astropy version. We did not have a TRUTH set so we were not sure which was correct. In addition I believe the astropy version (for some reason) was taking much longer than the version in the pipeline now.