spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
563 stars 167 forks source link

NIRCAM Mask File not setting DO_NOT_USE bit #6235

Closed stscijgbot-jp closed 2 years ago

stscijgbot-jp commented 3 years ago

Issue JP-2212 was created on JIRA by Michael Regan:

The current NIRCAM mask reference files are rarely setting the DO_NOT_USE bit for almost all of the non-nominal pixels. Only pixels identified as DEAD are always set to DO NOT USE. The other used flags of SATURATED, HOT, RC and NONLINEAR rarely set the DO NOT USE bit. All non ideal pixels should default to DO NOT USE. This will allow the level 3 mosaics to ignore those pixels when it creates the final mosaic. 

hbushouse commented 2 years ago

Closing this issue, because all of the work to be done is assigned to the INS NIRCam team and does not involve any code changes.

stscijgbot-jp commented 2 years ago

Comment by Karl Misselt on JIRA:

Can someone clarify why SATURATED is in a bad pixel mask? I don't recall; are these RC/HOT that reach well on first/second sample? Those should definitely be DO_NOT_USE.  RC (and IRC if tracked in the DMS pipeline masks) should probably be set DO_NOT_USE.  One could potentially recover some information in RC pixels that are still responsive by removing the RC signal via e.g. frame-by-frame dark correction, but I wouldn't trust em!  I also don't recall what NONLINEAR means in the context of a bad pixel mask.  Are these merged from e.g. the linearity masks for pixels which we were unable to derive a non-linearity correction?

stscijgbot-jp commented 2 years ago

Comment by Bryan Hilbert on JIRA:

Updated mask files have been delivered. The pixels previously flagged as NONLINEAR have had that flag removed. Those were the pixels originally flagged as WEIRD in the masks that Karl Misselt created. After discussing with him, we think those pixels should be treated as good. All pixels containing any other flags have had the DO_NOT_USE flag added.

stscijgbot-jp commented 7 months ago

Comment by David Law on JIRA:

Closing ticket; if still necessary will be addressed as part of upcoming DQ work