spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
563 stars 167 forks source link

NIRISS Mask File not setting DO_NOT_USE #6237

Closed stscijgbot-jp closed 2 years ago

stscijgbot-jp commented 3 years ago

Issue JP-2214 was created on JIRA by Michael Regan:

The current NIRISS mask reference files are not setting the DO_NOT_USE bit for all of the non-nominal pixels. Pixels identified as NONLINEAR, AD_FLOOR, DROPOUT rarely set the DO NOT USE bit. All non-ideal pixels should default to DO NOT USE. This will allow the level 3 mosaics to ignore those pixels when it creates the final mosaic. 

hbushouse commented 2 years ago

Closing this issue, because all of the work to be done is assigned to the INS MIRI team and does not involve any code changes.

stscijgbot-jp commented 2 years ago

Comment by Kevin Volk on JIRA:

The bad pixel mask code for NIRISS is written and maintained by Chris Willott.  I will coordinate with Chris about these flags and see what he says.  I had thought that pixels that Chris' code flags as nonlinear are flagged as DO_NOT_USE.  The other two flags are ones that I am not immediately familiar with in terms of the treatment in Chris' codes.  In any case, the plan is to use the commissioning darks to regenerate the bad pixel mask and these changes can be inserted at that time as needed.

 

 

stscijgbot-jp commented 2 years ago

Comment by Chris Willott on JIRA:

The NIRISS mask reference file generation code does set pixels identified as NONLINEAR and AD_FLOOR with the DO NOT USE bit. The latest version of the mask in CRDS did not have any pixels with these flags set because of incomplete analysis of linearity and superbias data. That will be corrected in future versions.

Could you clarify what you mean by DROPOUT for the mask reference file? My understanding is dropout is to be applied for science data that is lost in transmission. So how would this apply to a mask? There are no pixels that will always be lost in transmission. 

stscijgbot-jp commented 7 months ago

Comment by David Law on JIRA:

Closing ticket; if still necessary will be addressed as part of upcoming DQ work