spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
555 stars 161 forks source link

Group candidate ASN created for unrelated "sequence non-interruptible" visits #6278

Open stscijgbot-jp opened 3 years ago

stscijgbot-jp commented 3 years ago

Issue JP-2231 was created on JIRA by Hien Tran:

In NO11, 685:11 is a NIS focus sweep check and 685:12 is a NIS_WFSS confirmation observation that follows, both of which have the APT special requirement "sequence non-interruptible" specified.  

The generator created the -c1003 ASNs for image3 and spec3 for observations 11 and 12, but the -c1003 ASNs are identical to, and consisting exclusively of the same input members as those from -o012, and thus are their duplicates.

This is the same behavior reported in JWSTDMS-544 for NRC wavefront sensing visits.

stscijgbot-jp commented 1 year ago

Comment by Mark Kyprianou on JIRA:

Move to JP.  Update/review the association rules for this case.

stscijgbot-jp commented 4 months ago

Comment by David Law on JIRA:

Since this is an issue with pre-flight association generation I'm inclined to close it, but please reopen if this is something that still needs attention at some point.

stscijgbot-jp commented 4 months ago

Comment by Tyler Pauly on JIRA:

Could be considered a related ticket to JSSET-236

stscijgbot-jp commented 4 months ago

Comment by Rachel Plesha on JIRA:

Since the issue has not been resolved, this should be set to "on hold" instead. This will be completely lost forever if it is set to closed.

stscijgbot-jp commented 4 months ago

Comment by David Law on JIRA:

I think more the question is whether it still affects associations processed by DMS; if it only affected old NOps test cases (that may themselves have had issues) and did not reoccur going forward it would not be worth looking at.  Given Tyler Pauly 's comment about JSSET-236 though I'm going to lump this into the long-term technical debt category of items.

stscijgbot-jp commented 1 month ago

Comment by Rachel Plesha on JIRA:

We discussed this more in our recent ranking of tickets, and "non-interruptible" is not used by NIRISS WFSS on flight, so we should not run into this issue going forward.

Given that, we actually do agree that this ticket can be closed if the commissioning data are successfully in the archive. If they're not, then this ticket can be re-scoped for us to manually process them to give to the archive to statically archive.