search

spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
559 stars 166 forks source link

GLS ramp fitting bad input data should result in zero output, but results in NaNs. #6560

Open stscijgbot-jp opened 2 years ago

stscijgbot-jp commented 2 years ago

Issue JP-2377 was created on JIRA by Kenneth MacDonald:

A number of tests are failing to return expected zeros when bad data is inputed.  But test_nocrs_noflux_firstrows_are_nan and test_bad_gain_value should return zeros, but return NaNs.

stscijgbot-jp commented 5 months ago

Comment by David Law on JIRA:

Kenneth MacDonald Is this still relevant?  Generally I'd expect NaN slopes when there is no valid data to fit?

stscijgbot-jp commented 5 months ago

Comment by Kenneth MacDonald on JIRA:

David Law the GLS algorithm is still under development.  I have set of tickets for known problems with the existing code.  The GLS algorithm is low priority, so has not been worked on in a long time as other things have taken priority.

stscijgbot-jp commented 5 months ago

Comment by David Law on JIRA:

Kenneth MacDonald In that case I'll set this ticket to 'On Hold', agreed that there are higher priorities.