spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
558 stars 164 forks source link

1.4.0 skymatch #6654

Closed stscijgbot-jp closed 2 years ago

stscijgbot-jp commented 2 years ago

Issue JP-2489 was created on JIRA by JWST PARSER:

skymatch

1.4.0

1.4.2

hbushouse commented 2 years ago

Closing, because it's work that only needs to be tracked in JIRA.

stscijgbot-jp commented 1 year ago

Comment by Misty Cracraft on JIRA:

The MIRI notebook for calwebb_image3 shows that the current default value of the skymethod is set to match:

2022-03-23 13:23:14,487 - stpipe.Image3Pipeline.skymatch - INFO - Sky computation method: 'match' 2022-03-23 13:23:14,487 - stpipe.Image3Pipeline.skymatch - INFO - Sky matching direction: DOWN 2022-03-23 13:23:14,487 - stpipe.Image3Pipeline.skymatch - INFO - Sky subtraction from image data: OFF

Full notebook: https://jwst-validation-notebooks.stsci.edu/jwst_validation_notebooks/calwebb_image3/jwst_image3_miri_test/jwst_image3_miri_test.html

The skymatch notebook using noise images shows that each of the methods behave as expected. https://jwst-validation-notebooks.stsci.edu/jwst_validation_notebooks/skymatch/jwst_skymatch_miri_test/jwst_skymatch_miri_test.html

 

And the photometry/skymatch test notebook shows that, except for the global method (which should not be used with this dataset), the photometry for all other methods gives close agreement, so the step works well for most methods. (The global method should only be used on data that has previously been background subtracted.) https://jwst-validation-notebooks.stsci.edu/jwst_validation_notebooks/skymatch/jwst_skymatch_miri_test/jwst_skymatch_photom_miri_test.html

 

MIRI confirms this step is working as expected.

stscijgbot-jp commented 1 year ago

Comment by Jo Taylor on JIRA:

For NIRISS: Confirmed default skymatch method is now 'match'. Did not test goodness of skymatch itself.

stscijgbot-jp commented 1 year ago

Comment by Alicia Canipe on JIRA:

The step runs successfully for NIRCam and computes differences in sky values in overlapping regions. We currently have the subtraction off. No issues to report. https://jwst-validation-notebooks.stsci.edu/jwst_validation_notebooks/calwebb_image3/jwst_image3_nircam_test/jwst_image3_nircam_test.html